Re: [Rhythmbox-devel] playlist source burner 0.5

[Colin Walters <walters verbum org>]

On Fri, 2004-09-03 at 14:01 -0400, William Jon McCann wrote:

> Discs for the car were part of my motivation too.  However, Mr. James 
> can be a bit too much for me while in traffic.  I go with the new 
> Interpol or Ulrich Schnauss.  ;)

Heh, I'll have to check that out.

> For me, dropping in a playlist works with this patch but dropping into 
> the source pane itself does not.

Looks like Christophe has fixed this.

> I wasn't sure so I didn't change it yet.  At the moment, I'm thinking 
> that since the majority of people will never need to select a device 
> different from the default, they don't really need to see the selector. 
>   Showing it to them every time may be a bit much.  Maybe I'm 
> misunderstanding your suggestion.

I think Bastien's followup explained best.

> Actually, is db doing anything useful here?

Probably not...

> > This can be written in a cleaner way like this:
> > 
> > GtkTreeIter iter;
> > if (!gtk_tree_model_get_iter_first (model, &iter))
> >     return;
> > while (gtk_tree_model_iter_next (model, &iter)) {
> >  ...
> > }
> 
> Or this, right?
> 
> GtkTreeIter iter;
> if (!gtk_tree_model_get_iter_first (model, &iter))
>       return;
> do {
> ...
> } while (gtk_tree_model_iter_next (model, &iter);
> 

Yeah, sorry about that :)

> It is for efficiency since it reuses the converted audio tracks.  If you 
> want to make more than one copy it is fairly painful to have to convert 
> the audio each time.

What if we just cached the files for a minute?