Re: [Rhythmbox-devel] playlist source burner 0.5

[Colin Walters <walters verbum org>]

On Sat, 2004-09-04 at 02:51 +0100, Bastien Nocera wrote:

> The burn dialog is necessary anyway, just to confirm things before write
> starts (whether or not to have a 2 sec gap, the space on the CD, the
> usage, and the ability to cancel a possibly destructive process, etc.)
> so we might as well have the CD burner selection in there.
> And it also allows not to break the flow. If I was to start a burn with
> the wrong device, i'd have to cancel, and select the right drive, and go
> back to the burning dialog.

Yeah, makes a lot of sense to me.

> <snip>
> > > +        path = eel_gconf_get_string (CONF_STATE_BURN_TMP);
> > > +        if (path
> > > 
> > > You probably want: if (path && strcmp (path, "")
> > > The default GConf value seems to be "".
> > 
> > OK.
> 
> Actually, if (path && path[0] != '\0') is faster :)

strcmp is a GCC builtin, it will generate the same code.