Re: [Rhythmbox-devel] Rhythmbox 0.9



I thought I would note that I ran into this also at line 1071 and line
1076 of  rb-playlist-source-recorder.c, and used the type-cast (long
long int) fix, ala your patch.  It's now compiling for me and running
sort of. But sort of running is all I hoped for.

To what degree would you (the developer types) like bug reports on
0.9?  In other words, how can I help the best?  Would it be better for
me to point out issues I'm having or would it be better for me to shut
up and wait for it to stabilize a bit ;) ?

And would you rather they be posted here or filed in Bugzilla?

Thanks,
mike

On Mon, 08 Nov 2004 18:59:28 +0100, Christophe Fergeau <teuf gnome org> wrote:
> An alternative patch would be to replace %lld with G_GINT64_FORMAT but
> this has the disadvantage of not being really nice with translators :-/
> 
> Christophe
> 
> Le mardi 09 novembre 2004 à 00:28 +1000, Jonathan Matthew a écrit :
> 
> 
> > On Mon, Nov 08, 2004 at 12:39:14AM -0600, Michael Messmore wrote:
> > > I'm a bit curious to see how things are going with the 0.9 branch, and
> > > decided to check out a copy from the main arch repository.  I'm
> > > running Gentoo/amd64, so I don't know if its a 64-bit issue or not,
> > > but compilation died for me in rb-recorder-gst.c.
> > >
> > > rb-recorder-gst.c: In function `rb_recorder_burn':
> > > rb-recorder-gst.c:1101: warning: long long int format, gint64 arg (arg 5)
> > > rb-recorder-gst.c:1101: warning: long long int format, gint64 arg (arg 6)
> > >
> > > If this is a 64-bit issue, then consider this a bug note ;).
> >
> > It certainly looks that way to me.  Current 0.9 branch (plus some bits
> > I'm working on..) compiles fine for me on my primitive archaic 32-bit
> > machine.  Not being terribly familiar with glib types, or the sizes of
> > various types in 64-bit code, I'd be inclined to just add casts in
> > there.  Trivial patch below (obviously not tested), if anyone finds that
> > easier than doing it themselves.
> >
> > -jonathan.
> >
> > --- rb-recorder-gst.c.orig      2004-10-19 19:45:32.000000000 +1000
> > +++ rb-recorder-gst.c   2004-11-09 00:03:54.000000000 +1000
> > @@ -1097,8 +1097,8 @@
> >                               RB_RECORDER_ERROR_GENERAL,
> >                               _("This playlist is %lld minutes long.  "
> >                                 "This exceeds the %lld minute length of the media in the drive."),
> > -                             tracks_length / 60,
> > -                             media_length / 60);
> > +                             (long long int)(tracks_length / 60),
> > +                             (long long int)(media_length / 60));
> >                  return FALSE;
> >          }
> >
> >
> > _______________________________________________
> > rhythmbox-devel mailing list
> > rhythmbox-devel gnome org
> > http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
> >
> >
> 
> 
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
> 
> 
> 
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]