Re: [Rhythmbox-devel] [PATCH] Making it possible to delete thelast criterion in an automatic playlist

[Jacques Fortier <jfortier-rb blergl net>]

On Sat, 2004-05-01 at 00:36 -0400, Colin Walters wrote:
> I don't like this as-is.  Right now the add button is fairly clearly
> associated with adding the bottom row.  In LTR languages, you naturally
> scan from the left, modifying the criteria, and then Add is there
> waiting.  If we move it down, the association is less clear, IMO.
> 
> The current behavior is a bug too - but we don't want to trade one bug
> for another.  I'll ponder it a bit.

A few possibilities to ponder that I can think of. One is to make the
grouping more obvious by indenting the rows with the criteria and the
add button. Another possibility is to make the add button take up its
entire row, but I think that's pretty ugly. We could also put an add and
remove button on every row and continue to gray out the remove button
when there's only one row. Of course, this makes the dialog box pretty
wide. We'd also probably have to make it so that rows always get
inserted immediately after the row whose add button was clicked.

Jacques