Re: [Rhythmbox-devel] [PATCH] Making it possible to delete thelast criterion in an automatic playlist



On Thu, 2004-04-29 at 12:22, Jacques Fortier wrote:
> I got annoyed when I tried to delete the last criterion in an automatic
> playlist and found out I couldn't because the Remove button in that row
> was actually an Add button. The only way to delete the last row is to
> copy the contents of another row into the last row and then delete the
> row you just copied. It seems that the last row would probably be one of
> the most commonly removed rows, like when the user accidentally clicks
> on add.

Yeah.

> The patch below moves the add button onto its own row and puts it in the
> first column.

I don't like this as-is.  Right now the add button is fairly clearly
associated with adding the bottom row.  In LTR languages, you naturally
scan from the left, modifying the criteria, and then Add is there
waiting.  If we move it down, the association is less clear, IMO.

The current behavior is a bug too - but we don't want to trade one bug
for another.  I'll ponder it a bit.

This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]