Re: [Rhythmbox-devel] Proposed UI change to shuffle checkbox

On Wed, 2004-01-07 at 23:42, Jeffrey Yasskin wrote:

> The promised combo box is in my
> branch.
> The list of entries in it is in
> shell/rb-play-order.c:rb_play_order_get_orders(). If I've used the wrong
> control or you have a better string to suggest, please tell me.

I had a look at this.  My first impression is that it's not pretty :)
Now, I think the work you've done on abstracting out the play orders is
good - that code was all meshed confusingly before.

But do we really need to expose it in the UI in such a way?  My gut
feeling is that we should keep shuffle as a simple checkbox that is
enabled or not; that's all that I think most people will want.

It seems to me that the various Random modes are really a variant on
shuffle + repeat.  If I have shuffle + repeat on, that's where I would
expect it to choose songs randomly, since in effect the playlist is
infinitely long.  *Perhaps* there could be UI to change this in the
preference dialog.  I feel more though that we should try to pick one of
them that's just *right* for most people, and have a GConf key for
everyone else.

This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]