Hi, I finally gave a try to your arch tree (I also added it to rb website development page, it will show up when the web site is synced with the content of the arch repo). All in all, it's working really nicely though I'm not a big fan of the UI decisions :-/ I also had to apply the small attached patch, otherwise it crashed when I tried to play a song. The bottom left part of rb window is too big to display an amazon cover, some look really fuzzy... The "cover manager" should probably be integrated somehow with the song properties and extended to be a "fix my song tags using amazon" a bit like http://www.softpointer.com/images/TRAll.gif I'm not sure how to get that 100% right though since song properties are per song, and this "cover editor/tag fixer" would be per album. This is just food for thought anyway ;) Finally, I think I'd just grab the missing covers from amazon at startup without asking the user or requiring him to go to the cover editor. All in all, excellent travail ;) , cheers, Christophe Le jeudi 09 décembre 2004 à 16:47 +0100, Marc Pavot a écrit : > Hi, > > I have made a lot of changes in my arch branch for the support of the > album covers. It now works like this : > > *When you play a song : > - It search a cover in ~/.gnome2/rhythmbox/covers > - If none is found, it search a cover in the directory of the song > - If none is found, it search a cover on amazon.com > - If a cover is found in one of this place, the cover is displayed and > saved in ~/.gnome2/rhythmbox/covers. > > *When you launch the cover manager (screenshot : > http://perso.enst.fr/~pavot/Capture3.png > - It now shows all the covers found in ~/.gnome2/rhythmbox/covers with a > tree structure (Artist/Album) > - You can : > - Automatically get all the covers of an artist (or of all > artists) from the directory of the albums. > - Automatically download all the covers of an artist (or of all > artists) from amazon. > - Download a cover from amazon and select between different > covers and different sizes if you only select one album. > - Choose a cover for an album on your hard disk if you only > select one album. > > All your comments, ideas and bug reports are really welcome. > > Marc > > PS : my arch branch is here: > m pavot laposte net--2004 > http://perso.enst.fr/~pavot/archive > > > _______________________________________________ > rhythmbox-devel mailing list > rhythmbox-devel gnome org > http://mail.gnome.org/mailman/listinfo/rhythmbox-devel > >
* looking for m pavot laposte net--2004/rhythmbox--main--0.8--patch-17 to compare with
* comparing to m pavot laposte net--2004/rhythmbox--main--0.8--patch-17
M widgets/rb-album-cover.c
* modified files
--- orig/widgets/rb-album-cover.c
+++ mod/widgets/rb-album-cover.c
@@ -228,8 +228,8 @@
rb_album_cover_set_nocover (album_cover);
album_cover->priv->uri = NULL;
- album_cover->priv->artist = "";
- album_cover->priv->album = "";
+ album_cover->priv->artist = g_strdup ("");
+ album_cover->priv->album = g_strdup ("");
album_cover->priv->uri_has_changed = FALSE;
album_cover->priv->size = 0;
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=