Re: [Rhythmbox-devel] new error handling / skip unplayable patch


I had a quick look at that patch, overall it looks good, the only issue
I found is that rb_cell_renderer_pixbuf_activate is probably not working
as expected in RTL locales (the 
+	/* ensure the user clicks within the good cell */
+	if (mouse_x - cell_area->x >= 0
+	    && mouse_x - cell_area->x <= cell_area->width) {
part). The "error" icon also needs to be mirrored in RTL locales, it's
already done for the "playing" icon, so if your patch doesn't do that
yet, you can copy that.


Le mercredi 01 décembre 2004 à 18:17 -0500, William Jon McCann a écrit :
> Bastien Nocera wrote:
> > Hey William,
> > On Tue, 2004-11-30 at 21:55 -0500, William Jon McCann wrote:
> >>Hi,
> >>
> >>Here is a new patch that skips unplayable tracks rather than throw a 
> >>dialog (fixes #120974).  It also includes a few other fixes and my last 
> >>patch to disallow drops to smart playlists.
> >  
> > Could you get it to add a (!) icon when it can't play a track, so that
> > the fact that it's not playable is clear, as well as, possibly, a reason
> > for the playback failing in the properties window for that song?
> OK, here you go.  It used a stock close icon in the last patch because I
> doubted my artistic skills.  Which, as you can tell from the attached
> icon, are actually quite abundant.  ;)
> Jon
> PS. Damn that message size limit.
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org

Attachment: signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]