Re: [Rhythmbox-devel] [PATCH] FLAC stream info

On Tue, 2003-08-12 at 22:02, Joshua Haberman wrote:
> This patch fills in a lot of the missing functionality for FLAC stream
> info.  It reads all available information from VORBISCOMMENT metadata
> blocks in the file, and it correctly reads information such as file size
> and bitrate from the STREAMINFO block.  

Cool!  I've applied this patch in CVS.

> It can read this information
> from any source that gnome-vfs can handle, unlike my previous patch that
> required it to be a local file.

Good work, that makes things much more elegant.  Now we can more easily
bill Rhythmbox as able to play music over anything that gnome-vfs can

> Please let me know if anything needs to be improved.

The only thing I noticed is that you g_strdup () values a lot; you
probably want to use g_value_set_string_take_ownership instead of doing
a g_strdup (); g_value_set_string (); g_free ().  Otherwise, looks
pretty good to me.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]