Re: [Rhythmbox-devel] [Patch] Added a back button tho thesong-info dialog

[Bastien Nocera <hadess hadess net>]

On Fri, 2003-08-08 at 18:58, Carlos Perelló Marín wrote:
> El vie, 08-08-2003 a las 19:54, Bastien Nocera escribió:
> > On Fri, 2003-08-08 at 16:23, Carlos Perelló Marín wrote:
> > > Hi, here you have a patch to add a back button to the song-info dialog,
> > > this way the navigation is better.
> > > 
> > > Could I commit it?
> > 
> > First of all, you should refactor rb_song_info_backward_clicked_cb and
> > rb_song_info_backward_clicked_cb to just call another function passing
> > the direction as a parameter.
> > 
> > And why is there so much code to only add one new button there?
> 
> Hey, don't blame me, I just use the same code standard that I found
> there... :-P
> 
> It's the same code that someone else used to add the forward button...
> 
> If you let me I could improve it, I thought that I should implement it
> using something like the old code...

Don't blame me, I didn't look at anything but the patch ;)
So I guess it's alright. Could you still refactor
rb_song_info_backward_*_cb ?

Cheers

-- 
Bastien Nocera <hadess@hadess.net>