Re: Freeze break request for polari

+1 from the release team for the revised patch.

I notice that this category of bug (undo notification + quit) has
shown up more than once recently (I've seen it in boxes too)

On Fri, Mar 18, 2016 at 11:40 AM, Matthias Clasen
<matthias clasen gmail com> wrote:
I've commented on the patch in the first bug, with a request for clarification

On Fri, Mar 18, 2016 at 11:27 AM, Florian Müllner <fmuellner gnome org> wrote:

I'd like to push the fix in It's a minor and
straight-forward code change that fixes a fairly confusing issue:

 (1) we don't remove accounts immediately, but hide them from the UI
      and show an undo notification for some time; currently the account
      stays around hidden when the window is closed while the notification
      is still showing

 (2) the network list ( [+] -> Add Network ) doesn't allow to add networks
     that have already been added, they are insensitive and marked as
     "Already added"

The bug in (1) means that we can end up with "zombie" accounts, which is
already bad enough. However in combination with (2), those hidden accounts
prevent the user from re-adding the network in question.

Now that I'm already requesting a freeze break, I'll throw in as well. This is purely a
polish issue on non-GNOME systems (or when gnome-settings-daemon crashes):
GtkApplicationWindow:show-menubar cannot be set from .ui files when using
templates, so we end up with two fallback app menus (in both the headerbar
and the menubar) in those cases. I'd include the fix because it is trivial,
but considering that it usually doesn't affect GNOME, I wouldn't mind either
to wait for 3.20.1 ...

--- Florian

release-team gnome org
Release-team lurker? Do NOT participate in discussions.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]