Re: Gtk+ freeze break request

[Marek Kasik <mkasik redhat com>]

On 08/28/2014 12:19 AM, Matthias Clasen wrote:
> On Thu, Aug 21, 2014 at 8:14 AM, Marek Kasik <mkasik redhat com> wrote:
> > Bug 674264 - Credentials from gnome-keyring is not used while printing
> >  - https://bugzilla.gnome.org/show_bug.cgi?id=674264
> >
> > Andre Heinecke prepared a patch which adds ability to store passwords
> > using Secret service when printing to samba printers.
> >
> > From the UI point of view, the patch adds a check box "Remember
> > password" to the password dialog if the service is available.
> >
> > I've been testing and reviewing the code for quite a long time and I
> > think that it is ready to be pushed to Gtk+.

Hey Matthias,

> Hey Marek - sorry I totally missed this request (but then, I was on
> vacation...).

No problem, I hope you enjoyed your vacation :).

> It seems ok to me, just one question: I assume we already have the
> string translated in GTK+, right ?

Thank you. We don't have this string in Gtk+ yet. There is only
"Remember _forever" in gtkmountoperation.c.

Regards

Marek