Re: gnome-online-accounts freeze break request

[Frederic Peters <fpeters gnome org>]

Ryan Lortie wrote:

> On Mon, Sep 23, 2013, at 13:32, Ray Strode wrote:
> > In https://bugzilla.gnome.org/show_bug.cgi?id=705395 there's a fix for
> > GLib to prevent a deadlock in gnome-online-accounts.  That commit went
> > in at the "eleventh hour" and Dan Winship has expressed some concerns
> > it may be riskier than doing a workaround in gnome-online-accounts.
>
> We're going to need at least part of this patch in GLib eventually
> anyway, but I have misgivings about other parts of it.  The only reason
> I'm happy to accept the changes now is because I've discovered a path
> towards deprecating g_cancellable_disconnect() entirely.
>
> I have a patch for that already done, but it involves gsignal work and
> it's way too risky to do this cycle.
>
> All around, though, if we could wait until next cycle for all of these
> changes (to GLib), I would be much happier.  Approving Ray's request
> would let me do that.

I would have liked to hear Matthias take on this but as Ray is
confident about it, and Ryan is ok with it, here's my approval.


        Fred