Re: Freeze break request: EDS phone number support functions

Am Donnerstag, den 07.03.2013, 14:34 +0100 schrieb Frederic Peters:

Mathias Hasselmann wrote:

I want do land the attached patch. It adds GError arguments to 
the functions e_phone_number_get_country_code_for_region() and
e_phone_number_get_default_region(). This is to permit better error
handling and to avoid unit tests to break because of warnings, if phone
number support is missing.

The functions in question were newly introduced within the 3.8 cycle and
to far they only are used within EDS itself and outside of GNOME.

It looks fine, but is there an associated bug report, and ack from a
maintainer ?

Just got told about those issues on #evolution and then fixed them
quickly. Vadim was kind enough to create a bug report for the issue, so
that decisions are documented:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]