Re: freeze break request: fix at-spi2-atk crashes/warnings (BGO#684434)

[Frederic Peters <fpeters gnome org>]

> atk_bridge_adaptor_cleanup has a couple of problems that can cause
> crashes/aborts when a gtk+ application exits. It tries to free the
> wrong pointer, causing a crash (see
> https://bugzilla.gnome.org/show_bug.cgi?id=684434). It also
> derefernces libdbus connections without closing them, causing a
> SIGABRT if an AT is running.

The changes are simple and easy to understand, +1 from me.


> While testing this, I also found that, if an AT is running, then a
> DBusObjectPath is deregistered without having ever been registered,
> resulting in libdbus printing a warning, so I would like to fix this
> as well; I have attached a fix as a separate patch. It is a
> regression that I introduced recently when delaying initialization
> of the cache so that it will only be initialized when an AT is
> running.

This one on the other hand would require more knowledge than I have at
the moment, but I'll trust you nevertheless with a +1.


        Fred