Re: Code freeze break request for Evolution-Data-Server

[Matthias Clasen <matthias clasen gmail com>]

On Sat, Mar 24, 2012 at 10:02 AM, Andre Klapper <ak-47 gmx net> wrote:
> On Fri, 2012-03-23 at 16:16 -0400, Matthew Barnes wrote:
>> Having spent the day debugging frequent crashes in Evolution 3.3.92, I
>> now have a series of commits for the IMAPX backend which makes Evolution
>> sufficiently stable again for 3.4.0.
>>
>> Details and the patches are here:
>> https://bugzilla.gnome.org/show_bug.cgi?id=672717
>>
>> I'd like to get them in before Monday's release.  All of them.
>
> There is probably no easy way to get back the last hour that I spent
> reading the patches and surrounding code.
>
> The changes look fine to me (mostly adding debug spew and introducing
> getter/setter methods), plus I do want to see IMAPX stabilized to
> finally kill the "old" IMAP backend for 3.6 (so that there are not two
> IMAP account type options available for average users[1] - a PITA to
> document in the docs).
>
> I would have prefered to get this in earlier to receive more testing
> before 3.4.0, on the other hand the latest two IMAPX crasher reports
> only got reported after 3.3.92 (though there have been a few more
> reports since 2.30 or so).
>
> Slightly torn if getting this in right after 3.4.0 to have three more
> weeks of testing until 3.4.1 would be better, but before letting more
> users definitely run into crashes I'm giving one r-t approval with some
> free bellyache included, to hopefully let users run into less crashes
> (or at least crashes with better debug output to provide, so developers
> can fix them more easily for 3.4.1 which is probably shipped by most
> distros). :-/
>

Just in case it was unclear: after my testing, I'm in favor of
allowing these in too, which gives you the second approval.