Re: Freeze exception request for system-monitor

[Chris Kühl <blixtra gmail com>]

On Thu, Mar 22, 2012 at 1:06 PM, Andre Klapper <ak-47 gmx net> wrote:
> On Thu, 2012-03-22 at 07:24 -0400, Matthias Clasen wrote:
>> On Thu, Mar 22, 2012 at 7:23 AM, Chris Kühl <blixtra gmail com> wrote:
>> > On Thu, Mar 22, 2012 at 11:52 AM, Matthias Clasen
>> > <matthias clasen gmail com> wrote:
>> >> On Thu, Mar 22, 2012 at 6:37 AM, Chris Kühl <blixtra gmail com> wrote:
>> >>> Hiya,
>> >>>
>> >>> I'd like to request a freeze exception for a build issue in system-monitor.
>> >>>
>> >>> When enabling the new systemd support in system-monitor one gets a
>> >>> build error with systemd v43 due to a function parameter named 'class'
>> >>> in a header file. This makes it incompatible with C++ since 'class' is
>> >>> a C++ keyword. You'll find the bug and patch here:
>> >>> https://bugzilla.gnome.org/show_bug.cgi?id=668574
>> >>
>> >> Doesn't sound super-urgent to me, since all the patch does is disallow
>> >> building with systemd 43 - and that fails already...
>> >
>> > Yeah, but there is already a bug for that and there will probably be
>> > many more if we release without this patch.
>> >
>>
>> If there are any distros out there with 43, then certainly. Since the
>> patch looks right and harmless, +1 then.
>> Lets see what others think.
>
> Can't hurt to have an explicit error message already when running
> configure, keeping in mind the time spent for guessing the problem in
> the bug report.
>
> r-t approval 2 of 2.
>

It's pushed. thanks.

Chris

> andre
> --
> mailto:ak-47 gmx net | failed
> http://blogs.gnome.org/aklapper
>