[GTK+ hard code freeze] Revert gtk_menu_popup API break



Hello Matthias, hello release team,

I pinged on the bug twice, and the accerciser developer did as well,
but that didn't work. So let's try mail.

A while ago, the GI annotations for Gtk.Menu.poup_for_device() got
broken by renaming it to Gtk.Menu.popup() [1]. As I explained on the
bug [2] this is an API break and causes any application which
currently calls popup_for_device() to crash because it suddenly ceased
to exist. Also, it's conceptually wrong: these are two different
functions, taking different arguments, so a simple rename is
misleading and also breaks the documentation.

GI programs can just use popup_for_device(), or GI bindings like
pygobject or gjs are free to add adapters like [3] to emulate popup()
in terms of popup_for_device().

As hard code freeze will be EOD today, can we please revert this
before it gets into the official release?

The alternative would be to carry ugly workarounds in pygobject, gjs,
and friends, like "try to call popup_for_device, if that does not
exist, call popup with wrong arguments", and we would never be able to
drop them any more because we don't really know which software
currently uses that API.

Thanks for considering,

Martin

[1] http://git.gnome.org/browse/gtk+/commit/?id=dbd66a8f02a4f26a1650ab52ca7347f98c538367
[2] https://bugzilla.gnome.org/show_bug.cgi?id=657385
[3] http://git.gnome.org/browse/pygobject/tree/gi/overrides/Gtk.py#n1419
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]