Re: Hard code freeze break for gnome-themes-standard



On Wed, 2011-03-30 at 11:54 -0400, Matthias Clasen wrote:
> On Wed, Mar 30, 2011 at 11:48 AM, Cosimo Cecchi <cosimoc gnome org> wrote:
> > Hi,
> >
> > I made a patch that addresses [1] a glitch in Adwaita. Basically, we
> > override separator-width for the primary toolbar, to display separators
> > correctly, so GtkCombobox needs a special case if it's inside a primary
> > toolbar.
> >
> > Ok to push?
> >
> > [1] https://bugzilla.gnome.org/show_bug.cgi?id=646194
> >
> 
> Feels like a special-case that we will need to extend in the future,
> in case something else inside a toolbar or deeper nested looks at
> separator-width. But if it fixes the problem at hand, +1/2.

I agree; I tweaked the CSS patch to solve this in a generic way instead
and pushed it to gnome-themes-standard master and gnome-3-0.

Thanks,

Cosimo



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]