Re: More gnome-control-center patches

[Vincent Untz <vuntz gnome org>]

Bastien,

Le mardi 29 mars 2011, à 11:27 -0400, Matthias Clasen a écrit :
> On Tue, Mar 29, 2011 at 10:31 AM, Bastien Nocera <hadess hadess net> wrote:
> > On Tue, 2011-03-29 at 10:01 -0400, Matthias Clasen wrote:
> >> On Tue, Mar 29, 2011 at 9:33 AM, Bastien Nocera <hadess hadess net> wrote:
> >> > To stop the spinner mouse cursor:
> >> > https://bugzilla.gnome.org/show_bug.cgi?id=646045
> >>
> >> This one looks simple enough. We still don't have a solution for the
> >> problem with misleading application menu contents if you start e.g.
> >> network settings, then sound settings, and then go to 'all settings',
> >> right ?
> >> I can't find the bug about that right now, maybe the bugzilla outage ate it...
> >
> > I think it got eaten, yes.
> >
> >> > Avoid warning when looking for the default wallpaper:
> >> > https://bugzilla.gnome.org/show_bug.cgi?id=646056
> >>
> >> Are you sure we want to rule out symlinks here ?
> >
> > It's a hack to show the default Adwaita wallpaper first in the list. Not
> > going to cause much of a problem I don't think (there's already similar
> > code in the other codepaths loading XML files).
> >
> > If we wanted to allow symlinks, it would be a separate patch.
> 
> Ok, +1 then

I'm going to be a PITA, but really, please stop committing patches
before getting a second approval. Yes, those patches are fine, and
here's a second approval after the fact. But if we have a process like
this, this is for good reasons. So please try to be a bit more patient
and wait for a second approval for freeze breaks.

Vincent

-- 
Les gens heureux ne sont pas pressés.