Re: Freeze break request: "boxPointer" positioning for gnome-shell

[Matthias Clasen <matthias clasen gmail com>]

On Mon, Mar 28, 2011 at 11:20 AM, Owen Taylor <otaylor redhat com> wrote:
> I'd like to land my set of three patches in:
>
>  https://bugzilla.gnome.org/show_bug.cgi?id=645744
>
> They fix three things:
>
>  - They are an alternative fix to the crash when clicking on
>   notifications (https://bugzilla.gnome.org/show_bug.cgi?id=645697)
>
>  - The restore the slide animation that is supposed to happen when Shell
>   popup menus and notification bubble are opened. While it's
>   certainly not an essential feature, it's a nice touch, and it
>   seems lame to lose that slick touch that a contributor spent
>   a bunch of time on via accidental regression a few days before
>   the release.
>
>  - The fix a bunch of warnings that are spewed to stderr if you mouse
>   over other status icons while you have a right click menu on
>   a notification open.
>
> While they aren't tiny I'm pretty confident - the first patch is
> basically a cut-and-paste of code from Clutter, the second is a
> straightforward substitution, and the third patch takes some flawed
> code that we were adding layers of band-aids on top of and reworks
> it a simpler way.
>

Sounds good to me. +1/2