Re: Cheese patches
- From: Bastien Nocera <hadess hadess net>
- To: Frederic Peters <fpeters gnome org>
- Cc: release-team <release-team gnome org>
- Subject: Re: Cheese patches
- Date: Fri, 25 Mar 2011 19:57:18 +0000
On Fri, 2011-03-25 at 08:42 +0100, Frederic Peters wrote:
> Bastien Nocera wrote:
> > The largest patch ("Don't crop the video preview") uses a renamed
> > MxAspectFrame (currently under review in upstream Clutter), which was
> > already used within an Intel internal project. It works well in my
> > testing.
> But it introduces a dependency on an unspecified version of mx; will
> this work with the stable 1.0 serie of mx, or does it require 1.1?
> And mx is not even part of our stack...
I missed your mail, and committed and released a new Cheese. I know that
Mx isn't part of the stack, but it was the only way to get something
working in such a short time frame.
Feel free to revert it on master if that's not good enough. I'm happy
with this as it means that the Cheese widget works again.
> > "Make the flash not hide the gnome-shell panel" follows advice by Dan
> > Winship (IIRC) not put the flash over the shell panel. The majority of
> > the code is a cut'n'paste of code that's been used in Totem, and
> > gnome-desktop. Works well in my testing as well.
> No objection for this one.
Was pushed as well.
] [Thread Prev