Re: possible freeze change: at-spi2-core login race

On Fri, Mar 25, 2011 at 1:23 PM, Frederic Crozat <fred crozat net> wrote:
> On Fri, Mar 25, 2011 at 6:19 PM, Colin Walters <walters verbum org> wrote:
>> Hi,
>> Basically since GDM uses a11y, and on many GNOME installs GDM shares
>> an X server with the initial login, the AT_SPI_BUS environment
>> variable can be incorrectly picked up by the user login process.  This
>> patch ensures it gets cleared from the GDM session.
>> Needs approval from mgorse.
> For the record, I've tested this patch and it fixes gnome-shell being
> not accessible at startup (you needed to restart it, it was trying to
> use gdm accessibility buss).
> r-t approval 1/2 (assuming mgorse is fine with it, of course).

I think not putting this on the root window at all would be better,
and I don't really see how this fixes the race; I can only see it
preventing a dead property from leaking. But since testing seems to
conirm that it helps in practice, I'm ok with accepting this as a
bandaid fix.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]