Re: A few control-center patches

On Tue, 2011-03-22 at 13:58 -0400, Matthias Clasen wrote:
> On Tue, Mar 22, 2011 at 12:52 PM, Bastien Nocera <hadess hadess net> wrote:
> > Heya,
> >
> >
> > The first patch will port the sound panel's theme section to use
> > GSettings instead of GConf. This piece of code was somehow forgotten in
> > the process of porting the control-center to GSettings.
> >
> >
> > The second patch (the one that adds a new string), moves all the logging
> > infrastructure to be shared amongst panels. This makes
> > "gnome-control-center -v" work as expected, and be quiet by default.
> Both patches look good to me, so +1 from me.
> The second one adds a translatable string, but it only shows up in
> --help output.

I have a third patch as well, tested by Cosimo and myself:

Could I please get another +1 for the first 2 patches?

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]