Hi, Currently gnome-terminal crashes if the window manager crashes (or is restarted). See https://bugzilla.gnome.org/show_bug.cgi?id=630163 . The fix is a small change to ensure that _NET_WM_DESKTOP is set on the new X window, rather than a window that no longer exists. I would like approval to commit the patch (it has already been reviewed by Christian). Regards Chris --- From ecc82420bc343e1ab2c8f4ff9e5a468efc1520b9 Mon Sep 17 00:00:00 2001 From: Chris Coulson <chris coulson canonical com> Date: Mon, 20 Sep 2010 15:11:37 +0100 Subject: [PATCH] Bug 630163 - Set _NET_WM_DESKTOP on the new X window Set _NET_WM_DESKTOP on the new X window when handling composited-changed, rather than the old window (which has already been destroyed) --- src/terminal-window.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/terminal-window.c b/src/terminal-window.c index a4a8767..6501c84 100644 --- a/src/terminal-window.c +++ b/src/terminal-window.c @@ -1676,6 +1676,10 @@ terminal_window_composited_changed_cb (GdkScreen *screen, /* put the window back where it was before */ gtk_window_move (GTK_WINDOW (window), x, y); gtk_widget_realize (widget); + + /* Get new GdkWindow */ + widget_window = gtk_widget_get_window (widget); + gdk_x11_window_set_user_time (widget_window, user_time); if (was_minimized) -- 1.7.1
Attachment:
signature.asc
Description: This is a digitally signed message part