Re: Need more tarballs for 2.30.0

[Olav Vitters <olav vitters nl>]

On Wed, Mar 31, 2010 at 12:18:31AM +0200, Kjartan Maraas wrote:
> ti., 30.03.2010 kl. 23.11 +0200, skrev Vincent Untz:
> > Le mardi 30 mars 2010, à 20:30 +0000, Stef a écrit :
> > > On 03/30/2010 09:55 AM, Vincent Untz wrote:
> > > >Le mardi 30 mars 2010, à 13:59 +0000, Stef a écrit :
> > > >>I've attached a patch to that bug. Could you roll that into the release?
> > > >
> > > >Thanks, I've committed the patch (after requesting a freeze break). Now
> > > >I just need a tiny patch to make it build with Werror (which is required
> > > >for distcheck). See attachment.
> > > >
> > > >It's a bit ugly, but since there's no enum value in GnomeKeyringResult
> > > >for INCOMPLETE, I guess it's the only solution.
> > > 
> > > This is very strange, since I thought that in C an enum was defined
> > > to be an int, nothing more nothing less.
> > 
> > I guess it's because I have gcc 4.5. Here's the build log (that I forgot
> > to attach):
> > 
> > cc1: warnings being treated as errors
> > gkr-operation.c: In function ‘gkr_operation_set_result’:
> > gkr-operation.c:169:2: error: comparison between ‘GnomeKeyringResult’ and ‘enum <anonymous>’
> > gkr-operation.c: In function ‘gkr_operation_block’:
> > gkr-operation.c:370:39: error: comparison between ‘GnomeKeyringResult’ and ‘enum <anonymous>’
> > gkr-operation.c:375:58: error: comparison between ‘GnomeKeyringResult’ and ‘enum <anonymous>’
> > 
> Looks trivial to me. +1 from me if it still matters.

as per IRC 2/2 because I don't think it'll break anything

-- 
Regards,
Olav