Freeze break request for gedit
- From: Paolo Borelli <paolo borelli gmail com>
- To: GNOME Release Team <release-team gnome org>
- Subject: Freeze break request for gedit
- Date: Mon, 29 Mar 2010 20:15:23 +0200
Sorry for the very late notice, but it seems people have waited the last
day to test and report problems :(
https://bugzilla.gnome.org/show_bug.cgi?id=614205
It is a critical bug that causes crashes when saving files with utf8
characters. Patch is attached.
Ciao,
Paolo
diff --git a/gedit/gedit-document-input-stream.c b/gedit/gedit-document-input-stream.c
index 45cba7e..c3b7179 100644
--- a/gedit/gedit-document-input-stream.c
+++ b/gedit/gedit-document-input-stream.c
@@ -330,9 +330,19 @@ read_line (GeditDocumentInputStream *stream,
while (written < to_write)
{
+ gint w;
+
ptr = g_utf8_next_char (ptr);
- written = (ptr - buf);
- ++char_offset;
+ w = (ptr - buf);
+ if (w > to_write)
+ {
+ break;
+ }
+ else
+ {
+ written = w;
+ ++char_offset;
+ }
}
memcpy (outbuf, buf, written);
diff --git a/gedit/gedit-gio-document-saver.c b/gedit/gedit-gio-document-saver.c
index 7830c58..52dbd7c 100644
--- a/gedit/gedit-gio-document-saver.c
+++ b/gedit/gedit-gio-document-saver.c
@@ -354,6 +354,8 @@ write_file_chunk (AsyncData *async)
{
GeditGioDocumentSaver *gvsaver;
+ gedit_debug (DEBUG_SAVER);
+
gvsaver = async->saver;
g_output_stream_write_async (G_OUTPUT_STREAM (gvsaver->priv->stream),
@@ -372,6 +374,8 @@ read_file_chunk (AsyncData *async)
GeditDocumentInputStream *dstream;
GError *error = NULL;
+ gedit_debug (DEBUG_SAVER);
+
gvsaver = async->saver;
async->written = 0;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]