Re: Brasero Code freeze break

[Vincent Untz <vuntz gnome org>]

Le dimanche 15 mars 2009, à 16:18 +0100, Philippe Rouquier a écrit :
> Hi,
> 
> reading the code one last time, I stumbled about this:
> 
> BraseroBurnResult
> brasero_track_set_audio_info (BraseroTrack *track,
> 			      BraseroSongInfo *info)
> {
> 	BraseroTrackAudio *audio;
> 
> 	if (track->type.type != BRASERO_TRACK_TYPE_AUDIO)
> 		return BRASERO_BURN_NOT_SUPPORTED;
> 
> 	audio = (BraseroTrackAudio *) track;
> 
> 	if (audio->info)
> 		brasero_song_info_free (info);
> 
> 	audio->info = info;
> 	return BRASERO_BURN_OK;
> }
> 
> which is stupid since it sometimes destroys info variable contents
> before saving the pointer for later use.
> So the simple fix is;
> 
> -  brasero_song_info_free (info)
> + brasero_song_info_free (priv->info)

If you mean "audio->info" instead of "priv->info", then approval 1 of 2.

Vincent

-- 
Les gens heureux ne sont pas pressés.