Re: gedit code break request (fsync)

[Andre Klapper <ak-47 gmx net>]

Am Samstag, den 14.03.2009, 18:51 +0100 schrieb Vincent Untz:
> Le vendredi 13 mars 2009, à 16:07 +0100, Paolo Borelli a écrit :
> > Il giorno ven, 13/03/2009 alle 14.58 +0100, Vincent Untz ha scritto:
> > > Hi Paolo,
> > > 
> > > Le vendredi 13 mars 2009, à 14:19 +0100, Paolo Borelli a écrit :
> > > > Hi,
> > > > 
> > > > 	I ask permission to apply the attached patch. It is the gedit
> > > > counterpart to the request explained by Alex in
> > > > http://mail.gnome.org/archives/gtk-devel-list/2009-March/msg00082.html
> > > > 
> > > > In gedit it should be less controversial since we are always writing a
> > > > single file, so there are no heavy performance implications.
> > > 
> > > How strong do you feel about this change? ie, do you think it's badly
> > > needed?
> > > 
> > 
> > Well, I think it's pretty important for systems using ext4 (see the
> > other discussion about the generic glib patch) and since in the case of
> > gedit we are just talking about calling fsync when explicitly saving a
> > file (no recursive copies or anything) I do not think it has bad
> > performance downsides.
> > So yes, I think it should go in before the release.
> 
> Approval 1 of 2, then.
> 
> Vincent

Oh right, another request...
Approval 2 of 2 (after reading part of the pdf presentation on this).

andre
-- 
 mailto:ak-47 gmx net | failed
 http://www.iomc.de/  | http://blogs.gnome.org/aklapper