Re: Evince bug 495107 =?utf-8?B?4oCTIEhh?= =?utf-8?Q?ndle?= print dialog responses correctly



2008-03-09 klockan 16:14 skrev Vincent Untz:
> Le dimanche 09 mars 2008, à 14:02 +0100, Olav Vitters a écrit :
> > On Sun, Mar 09, 2008 at 01:48:23PM +0100, Wouter Bolsterlee wrote:
> > > 2008-03-09 klockan 13:46 skrev Olav Vitters:
> > > > On Sun, Mar 09, 2008 at 01:43:08PM +0100, Wouter Bolsterlee wrote:
> > > > > I've justed committed a trivial Evince patch to fix this blocker bug that
> > > > > breaks printing for ALL users:
> > > > > 
> > > > >   Bug 495107 – Handle print dialog responses correctly
> > > > >   http://bugzilla.gnome.org/show_bug.cgi?id=495107
> > > > > 
> > > > > With this patch we're breaking hard code freeze. Please approve post-commit.
> > > > 
> > > > Note that you should ask before committing. It doesn't matter as this
> > > > was already approved yesterday.
> > > 
> > > Sorry, I realized after committing. Didn't know about previous approval
> > > though.
> > 
> > After some IRC stuff: patch from yesterday didn't work. Approval 1/2 to
> > fix that.
> 
> Approval 2 of 2.

Thanks for the approval!

> (Wouter, please, don't commit before approval, even if the patch seems
> trivial and you're right ;-))

Yeah, I know... I'll repeat after myself: "Sorry, I realized after
committing. Didn't know about previous approval though." ;)

  mvrgr, Wouter

-- 
:wq                                                       mail uws xs4all nl
                                                      web http://uwstopia.nl

if this is right :: i'd rather be wrong :: rather be blind        -- incubus

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]