Re: HC Freeze break
- From: Srinivasa Ragavan <sragavan novell com>
- To: Karsten Bräckelmann <guenther rudersport de>
- Cc: release-team gnome org
- Subject: Re: HC Freeze break
- Date: Mon, 17 Sep 2007 07:07:04 +0530
Thanks release-team. Committed to gnome-2-20 branch, and would do the
same to trunk as well.
-Srini.
On Mon, 2007-09-17 at 02:46 +0200, Karsten Br�elmann wrote:
> > The attached patch would fix that break and I have tested it well (I
> > couldn't have build Evolution otherwise) as well as it doesn't introduce
> > any new issues and works fine.
> >
> > The release planning wiki for Hard code freeze says: Simple build fixes
> > are, of course, allowed without asking.
> >
> > I wasn't sure if this is that category or not, felt better to ask it
> > anyways.
>
> Not sure either, as I mentioned on IRC already -- because it involves
> the actual code as opposed to configure and friends magic only. On the
> other hand, it effectively just works around the #ifdef for 'client'
> defined in configure.in... If this indeed is a "simple build fix", I'm
> positive someone else will point it out. Otherwise...
>
> As per your explanation above, the provided patch and our discussion on
> IRC
>
> Approval 1 of 2.
>
> Thanks for asking in either case.
>
> guenther
>
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]