Re: request to apply fix for gtktreeview accessibility

[Vincent Untz <vuntz gnome org>]

Le vendredi 10 mars 2006 �1:55 -0700, Elijah Newren a �it :
> On 3/10/06, Bill Haneman <Bill Haneman sun com> wrote:
> > Hi:
> >
> > In an attempt to fix bug 326362
> > http://bugzilla.gnome.org/show_bug.cgi?id=326362
> >
> > an incorrect fix was applied to gailtreeview.c on about Feb 21.  This
> > caused a serious regression which makes Gnome-2.14 useless to blind
> > users.
> >
> > We have identified the problem with the original fix, and have traced
> > the root cause of the crash to gtk+.  In both cases we have one-line
> > code changes which revert the incorrect fix to gail, and which prevent
> > the gtk+ segfault.
> >
> > I am requesting permission to apply the following two patches.  In
> > particular I would like permission to apply the gail patch, which
> > reverts the bad fix; however it seems reasonable to apply a more correct
> > fix (to gtk+) at the same time.  If the gtk+ team would rather do the
> > latter, that's fine by me.
> 
> Ouch, looks pretty bad.  But the solution looks small and safe and it
> appears that Matthias has commented on the bug to say as much about
> the gtk patch.  So, approval 1 of 2 from me.

2/2.

Vincent

-- 
Les gens heureux ne sont pas press�