Vte: Request to break code freeze

[Behdad Esfahbod <behdad cs toronto edu>]

Hi,

After vte-0.11.18 which was a great success, I made a silly
change among other things, that makes vte unusable with very tall
windows.  What exactly I did was to change the timeout between
two updates from 25ms to number-of-rows milliseconds!  The
details is here:

  http://bugzilla.gnome.org/show_bug.cgi?id=333776


That was a real mistake now that I think about it though.  So I'm
seeking permission to commit the following patch:

Index: vte-private.h
===================================================================
RCS file: /cvs/gnome/vte/src/vte-private.h,v
retrieving revision 1.3
diff -u -p -d -r1.3 vte-private.h
--- vte-private.h       1 Mar 2006 01:44:40 -0000       1.3
+++ vte-private.h       8 Mar 2006 04:22:40 -0000
@@ -84,6 +84,7 @@ G_BEGIN_DECLS
 #define VTE_COALESCE_TIMEOUT           10
 #define VTE_DISPLAY_TIMEOUT            10
 #define VTE_UPDATE_TIMEOUT             10
+#define VTE_UPDATE_REPEAT_TIMEOUT      25

 /* The structure we use to hold characters we're supposed to display -- this
  * includes any supported visible attributes. */
Index: vte.c
===================================================================
RCS file: /cvs/gnome/vte/src/vte.c,v
retrieving revision 1.441
diff -u -p -d -r1.441 vte.c
--- vte.c       1 Mar 2006 01:44:40 -0000       1.441
+++ vte.c       8 Mar 2006 04:22:42 -0000
@@ -228,7 +228,7 @@ vte_update_timeout(VteTerminal *terminal
        /* Set a timer such that we do not invalidate for a while. */
        /* This limits the number of times we draw to ~40fps. */
        terminal->pvt->update_timer = g_timeout_add_full (G_PRIORITY_DEFAULT_IDLE,
-                                                         terminal->row_count,
+                                                         VTE_UPDATE_REPEAT_TIMEOUT,
                                                          vte_update_delay_timeout,
                                                          terminal,
                                                          NULL);


--behdad
http://behdad.org/

"Commandment Three says Do Not Kill, Amendment Two says Blood Will Spill"
	-- Dan Bern, "New American Language"