EOG hard-code freeze break

["Lucas Rocha" <lucasr gnome org>]

Hi all,

Currently EOG uses Ctrl+(PgDown|PgUp) to switch to next/previous image
in a collection. In order to be HIG compliant and be coherent with
other GNOME apps which have navigation actions (Epiphany, Nautilus,
others), EOG should switch to next/previous images with
Alt+(Left|Right). Alt+Home to first image and Alt-End to last one. See
bug #330403.

The patch bellow changes the default shortcut to the Alt+{Left,Right}
shortcuts from the HIG and keeps the old ones secretly available.

The EOG manual is quite outdated (shame on me!) so these new shortcuts
won't have any real impact on it.

I'm sorry to request this now. I didn't have much time to work on
GNOME in the last month. Too much things for the last minute. ;-/

p eace

--lucasr

Index: shell/eog-gtk-ui.xml
===================================================================
RCS file: /cvs/gnome/eog/shell/eog-gtk-ui.xml,v
retrieving revision 1.15
diff -u -r1.15 eog-gtk-ui.xml
--- shell/eog-gtk-ui.xml	9 Jan 2006 04:35:50 -0000	1.15
+++ shell/eog-gtk-ui.xml	8 Mar 2006 02:47:51 -0000
@@ -76,4 +76,6 @@
   <accelerator name="ShiftReturnAccel" action="ShiftReturn"/>
   <accelerator name="BackSpaceAccel" action="BackSpace"/>
   <accelerator name="DeleteAccel" action="Delete"/>
+  <accelerator name="ControlPgUpAccel" action="ControlPgUp"/>
+  <accelerator name="ControlPgDownAccel" action="ControlPgDown"/>
 </ui>
Index: shell/eog-window.c
===================================================================
RCS file: /cvs/gnome/eog/shell/eog-window.c,v
retrieving revision 1.185
diff -u -r1.185 eog-window.c
--- shell/eog-window.c	6 Mar 2006 22:49:03 -0000	1.185
+++ shell/eog-window.c	8 Mar 2006 02:47:59 -0000
@@ -3316,6 +3316,8 @@
   { "ShiftReturn", NULL, N_("_Previous Image"), "<shift>Return", NULL, G_CALLBACK (verb_GoPrev_cb) },
   { "BackSpace", NULL, N_("_Previous Image"), "BackSpace", NULL, G_CALLBACK (verb_GoPrev_cb) },
   { "Delete", NULL, N_("Move to _Trash"), "Delete", NULL, G_CALLBACK (verb_MoveToTrash_cb) },
+  { "ControlPgUp", NULL, N_("_Previous Image"), "<control>Page_Up", NULL, G_CALLBACK (verb_GoPrev_cb) },
+  { "ControlPgDown", NULL, N_("_Next Image"), "<control>Page_Down", NULL, G_CALLBACK (verb_GoNext_cb) },
 };
 
 static const GtkToggleActionEntry toggle_entries_image[] = {
@@ -3323,10 +3325,10 @@
 };
 
 static const GtkActionEntry action_entries_collection[] = {
-  { "GoPrevious", GTK_STOCK_GO_BACK, N_("_Previous Image"), "<control>Page_Up", NULL, G_CALLBACK (verb_GoPrev_cb) },
-  { "GoNext", GTK_STOCK_GO_FORWARD, N_("_Next Image"), "<control>Page_Down", NULL, G_CALLBACK (verb_GoNext_cb) },
-  { "GoFirst", GTK_STOCK_GOTO_FIRST, N_("_First Image"), "<control>Home", NULL, G_CALLBACK (verb_GoFirst_cb) },
-  { "GoLast", GTK_STOCK_GOTO_LAST, N_("_Last Image"), "<control>End", NULL, G_CALLBACK (verb_GoLast_cb) },
+  { "GoPrevious", GTK_STOCK_GO_BACK, N_("_Previous Image"), "<alt>Left", NULL, G_CALLBACK (verb_GoPrev_cb) },
+  { "GoNext", GTK_STOCK_GO_FORWARD, N_("_Next Image"), "<alt>Right", NULL, G_CALLBACK (verb_GoNext_cb) },
+  { "GoFirst", GTK_STOCK_GOTO_FIRST, N_("_First Image"), "<alt>Home", NULL, G_CALLBACK (verb_GoFirst_cb) },
+  { "GoLast", GTK_STOCK_GOTO_LAST, N_("_Last Image"), "<alt>End", NULL, G_CALLBACK (verb_GoLast_cb) },
 };
 
 typedef struct {