patch approval request
- From: Christian Persch <chpe gnome org>
- To: release-team gnome org
- Subject: patch approval request
- Date: Tue, 07 Mar 2006 23:32:32 +0100
Hi,
I'd like to ask for approval to check the patch
[http://bugzilla.gnome.org/attachment.cgi?id=60868&action=view, also
attached] from bug 33780
[http://bugzilla.gnome.org/show_bug.cgi?id=333780] in.
The patch has no risk, and fixes a problem where web sites do not check
JS exceptions when they call window.confirm() which might cause a
dataloss. The patch makes epiphany return the same value to the web site
on ESC as when the Cancel button is pressed.
Regards,
Index: embed/mozilla/EphyPromptService.cpp
===================================================================
RCS file: /cvs/gnome/epiphany/embed/mozilla/EphyPromptService.cpp,v
retrieving revision 1.9
diff -p -u -u -p -r1.9 EphyPromptService.cpp
--- embed/mozilla/EphyPromptService.cpp 5 Mar 2006 20:54:32 -0000 1.9
+++ embed/mozilla/EphyPromptService.cpp 7 Mar 2006 21:31:55 -0000
@@ -68,7 +68,7 @@ enum
RESPONSE_ABORT_SCRIPT = 42
};
-#define RETVAL(r) ((r) == GTK_RESPONSE_DELETE_EVENT ? NS_ERROR_FAILURE : NS_OK)
+#define RETVAL(r) (NS_OK)
class Prompter
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]