Re: Zenity hard-code freeze break

["Vincent Untz" <vuntz gnome org>]

Hey,

On Tue, March 7, 2006 13:26, Lucas Rocha wrote:
> Hi Vincent,
>
>> > I'd like to do very little fix on the "separator" list dialog option.
>> > Just to add the G_OPTION_FLAG_NOALIAS flag to avoid the alias
>> > "list-separator". Here's the patch:
>>
>> >From the doc:
>>
>> "This option should only be used in situations where aliasing is
>> necessary to model some legacy commandline interface. It is not safe to
>> use this option, unless all option groups are under your direct
>> control."
>>
>> >From zenity help output:
>>
>>   --help-gtk                     Show GTK+ Options
>>
>> You don't have direct control over this one...
>
> Just to make things clear: separator is an option that's being used in
> more than one dialog. There's already other groups are using the
> NO_ALIAS flag with no problem. The point here is that I forgot to add
> the flag in the list dialog group.

Good to know.

>> Also, two questions:
>>
>>  + what is documented in the help? separator or list-separator?
>
> "--separator" is documented, not "--list-separator".
>
>>  + what string was used in previous versions? It's important to keep
>>    compatibility.
>
> There's no backward compatibility break here. I'm sure.

Just tried with a 2.10.0 version (which also lists --list-separator
in its help output) and both options work.

Thanks for your answers. This is not a critical fix and it's been here
for a long time, but it works for other options. So one approval from me.

Vincent

-- 
Les gens heureux ne sont pas pressés.