Re: Nautilus freeze break request

[Alexander Larsson <alexl redhat com>]

On Tue, 2006-03-07 at 11:14 +0100, Vincent Untz wrote:
> On Tue, March 7, 2006 10:48, Alexander Larsson wrote:
> > In gnome 2.12 we added some special case semantics to
> > gnome_vfs_drive/volume_mount() to support modern mount helper. If the
> > mount helper displays error dialogs itself we return an error string of
> > "", and in this case the app shouldn't display any error dialog.
> >
> > Nautilus has code that handles this in the eject and unmount case, but
> > we apparently forgot this for the mount case. The attached patch fixes
> > this. Without it you'll get a real error dialog plus an empty one when
> > mounting a volume failed (if you're using gnome-mount or hal-mount).
> >
> > Ok to commit?
> 
> Second part of the patch contains an empty block for the if ("if () {}
> else {...}) but if you like it this way, that's not a problem :-)

Its not exactly super-nice, but I wanted to change the code (its copied
from elsewhere in the file) as little as possible to avoid bugs creeping
in.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an oversexed sweet-toothed inventor moving from town to town, helping 
folk in trouble. She's a mentally unstable psychic soap star with a 
flame-thrower. They fight crime!