Re: Nautilus freeze break request



On Tue, March 7, 2006 10:48, Alexander Larsson wrote:
> In gnome 2.12 we added some special case semantics to
> gnome_vfs_drive/volume_mount() to support modern mount helper. If the
> mount helper displays error dialogs itself we return an error string of
> "", and in this case the app shouldn't display any error dialog.
>
> Nautilus has code that handles this in the eject and unmount case, but
> we apparently forgot this for the mount case. The attached patch fixes
> this. Without it you'll get a real error dialog plus an empty one when
> mounting a volume failed (if you're using gnome-mount or hal-mount).
>
> Ok to commit?

Second part of the patch contains an empty block for the if ("if () {}
else {...}) but if you like it this way, that's not a problem :-)

One approval from me since it will obviously show an useless empty
dialog.

Vincent

-- 
Les gens heureux ne sont pas pressés.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]