Re: [PATCH] Freeze breakage: Fix URI activation cancellation for panel

[Alexander Larsson <alexl redhat com>]

On Mon, 2005-10-17 at 21:17 +0200, Christian Neumair wrote:
> Am Montag, den 17.10.2005, 10:20 +0200 schrieb Alexander Larsson:
> > On Fri, 2005-10-14 at 16:51 +0200, Christian Neumair wrote:
> > > The attached patches are meant to fix cancellation of URI activations
> > > through the panel. They are against libgnome, gnome-panel and gnome-vfs,
> > > and break string freeze, and potentially even API freeze. I wonder
> > > whether adding an element to a public enum is consiered an API change.
> > > 
> > > Life would have been easier if GnomeURLError used negative error codes,
> > > reserving all >= 0 for GnomeVFSResult retvals.
> > 
> > GnomeURLError was written before gnome_vfs_show_url existed...
> > 
> > > I've also CCed random people that often occur in recent ChangeLogs of
> > > the affected producs and/or released tarballs. MAINTAINERS files aren't
> > > up to date for any of these.
> > 
> > The gnome-vfs patch should really modify _gnome_vfs_get_slow_mime_type()
> > (it is the only used for this function) instead of copying it into the
> > function.
> 
> Yes, I know. I just didnt want to change that header. You reminded me
> that even private API deserves some attention. Attaching a new patch
> set.
> 
> What do you propose to resolve the
> gnome_vfs_get_mime_type/_gnome_vfs_get_slow_mime_type signature
> inconsistency the change introduces, considering that
> _gnome_vfs_get_slow_mime_type is very likely to become public one day,
> if not for GnomeVFS 2.14?

One could expose the public version of the function which is similar to
gnome_vfs_get_mime_type, which just calls the current (patched)
_gnome_vfs_get_slow_mime_type. That makes the public interface similar,
and they are just helper functions anyway, so the slight limitation
doesn't really hurt much.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a maverick flyboy master criminal in a wheelchair. She's a warm-hearted 
renegade doctor with a song in her heart and a spring in her step. They fight 
crime!