Re: [PATCH] Freeze breakage: Fix URI activation cancellation for panel

[Alexander Larsson <alexl redhat com>]

On Fri, 2005-10-14 at 16:51 +0200, Christian Neumair wrote:
> The attached patches are meant to fix cancellation of URI activations
> through the panel. They are against libgnome, gnome-panel and gnome-vfs,
> and break string freeze, and potentially even API freeze. I wonder
> whether adding an element to a public enum is consiered an API change.
> 
> Life would have been easier if GnomeURLError used negative error codes,
> reserving all >= 0 for GnomeVFSResult retvals.

GnomeURLError was written before gnome_vfs_show_url existed...

> I've also CCed random people that often occur in recent ChangeLogs of
> the affected producs and/or released tarballs. MAINTAINERS files aren't
> up to date for any of these.

The gnome-vfs patch should really modify _gnome_vfs_get_slow_mime_type()
(it is the only used for this function) instead of copying it into the
function.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a superhumanly strong shark-wrestling boxer with a robot buddy named 
Sparky. She's a time-travelling thirtysomething safe cracker with an 
incredible destiny. They fight crime!