Re: [Epiphany] Request for advice regarding patch

[Christian Persch <chpe gnome org>]

Hi,

Le samedi 23 juillet 2005 �1:47 -0600, Elijah Newren a �it :
> On 7/23/05, Luis Villa <luis villa gmail com> wrote:
> > On 7/23/05, Luis Villa <luis villa gmail com> wrote:
> > > On 7/23/05, Christian Persch <chpe gnome org> wrote:
> > > > Hi,
> > > >
> > > > there's a patch for Epiphany
> > > > [http://bugzilla.gnome.org/attachment.cgi?id=49600&action=view] in bug
> > > > 141241 [http://bugzilla.gnome.org/show_bug.cgi?id=141241] which makes
> > > > Epiphany use the GNOME print dialogues from libgnomeprintui. It's mostly
> > > > an UI change but could also be viewed as a feature; since we're past
> > > > feature freeze, I'd like to ask about your opinion.
> > > >
> > > > Reasons I'd like to get this in:
> > > > - improves GNOME integration of Epiphany
> > > > - fixes some printing bugs [#163255, #301730]
> > >
> > > Urgh. This is fairly borderline. :/ But given the known issues with
> > > epiphany printing, and the  very laudable goal of better integration,
> > > I say go for it. Hopefully I'll buy a printer soon and will be able to
> > > test ;)
> 
> Well it's kind of scary as it's a relatively new patch.  So I'm kind
> of worried.  But, it fixes important bugs, will help with
> libgnomeprint testing, and it looks like you're working off an old XD2
> patch and evince is doing similar stuff...since it's not too long
> after feature freeze here's approval 2 of 2.

Thanks! Committed to cvs.

	Christian