Re: Approval required for a fix in evolution-data-server module (Re: [evolution-patches] [EDS-libedataserver] Fix for #271969)

[Vincent Untz <vuntz gnome org>]

Le mardi 16 ao�05 �9:11 -0400, Luis Villa a �it : 
> On 8/16/05, Veerapuram Varadhan <vvaradhan novell com> wrote:
> > On Tue, 2005-08-16 at 08:38 -0400, Luis Villa wrote:
> > > On 8/16/05, Veerapuram Varadhan <vvaradhan novell com> wrote:
> > > > Hi,
> > > >
> > > > The fix for http://bugzilla.gnome.org/show_bug.cgi?id=271969 requires a
> > > > function to be added to an exposed header file in evolution-data-server
> > > > module, thus breaking the *norms* of API freeze.
> > > >
> > > > Below mail-thread and the above bugzilla link will give you complete
> > > > information as to why this fix is *very critical* for the forth coming
> > > > Evolution 2.4 release.
> > > >
> > > > I request you to kindly approve this fix ASAP.
> > >
> > > I'm not quite sure what is being asked here- the referenced bug says
> > > nothing about a new function,
> > The patch in
> > http://bugzilla.gnome.org/attachment.cgi?id=50785&action=view
> > exposes a new function (pasted below for reference) in
> > e-d-s/libedataserver/e-xml-hash-utils.h.
> > 
> > +void           e_xmlhash_foreach_key_remove (EXmlHash     *hash,
> > +                                     EXmlHashRemoveFunc  func,
> > +                                     gpointer      user_data);
> > +
> > 
> > and since, the new function is added to an exposed header-file, I
> > thought it could break the API freeze, so requested for an approval.
> 
> I see. It does technically violate the freeze; but given that no one
> guarantees api stability for e-d-s, and this is an addition and not a
> change/removal, this is fine. [I think- I'd love someone else from r-t
> to weigh in on this.]

Agreed. And it fixes a bad bug. I'll assume it's not causing problems
for some bindings.

Approval 1 of 2.

However, I'm a bit surprised to see so many freeze break requests only
for evolution: there are not so many requests for the other modules.
Maybe there's something to change here...

Vincent

-- 
Les gens heureux ne sont pas press�