Re: Please be careful with type handling

[Martin Pitt <martin pitt ubuntu com>]

Hello Alberto,

Alberto Mardegan [2012-10-10 11:01 +0300]:
> I just filed https://bugzilla.gnome.org/show_bug.cgi?id=685860

Good catch, thanks! Fixed yesterday with a test.

> For instance, the very issue which made me write this, is that the
> commit which introduced the _pygi_hash_pointer_to_arg() function also
> has the reverse function, _pygi_arg_to_hash_pointer(), which handles
> more types, so the asymmetry was not hard to notice:
> 
> http://git.gnome.org/browse/pygobject/commit/?id=1c5d497d3c354f4d02f1d4570df2c61d6f47300c

Indeed this should have been picked up in the review, sorry about
that.

> Keep up the great work! :-)

Thanks!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)