On Sun, Jun 14, 2009 at 04:56:56PM +0200, Gabriel Camby wrote: > I'll be glad if you tell me what you think of it. First of all, nice work! I'm sure this functionality will be useful for a lot of our users. Here's a couple of things I noticed during my initial review: 1) The patch is not well formed. It has white space issues (git apply complains) and has Windows line endings in it. 2) Let's call the center of the edge between the completed part of a task and the part that still needs to be done the "progress point". The slipline is a vertical line at a selected date that goes from selected date above the task bar to the progress point and then back to the selected date below the task bar. Because the slip line crosses the edges of the task bar about half-way between the progress point and the selected date, it looks to me like things are not as far behind or ahead of planning as they really are. I think that if the slipline would connect to task bar edges above and below the progress point, it would be clearer. Then again, maybe I'm completely wrong here and everybody is used to have sliplines like they are now. I'm not a project manager. Anyone with project management experience, please chip in =) 3) The PERT functionality does not seem to work with summary tasks. Suppose A is a summary task, B its subtask and task A can't start until C has been finished. Then in the PERT chart I can see A after C, but B is parallel to C. 4) There doesn't seem to be enough room for durations in the PERT chart. I think it happens when a task duration is "7d 4h" or "138d". 5) Task names seem to be modified if they are too long to fit in the PERT chart. This modification then also shows up in the task list and in the Gantt chart. I think pango can render text within a limited space and render ellipsis when necessary, so you won't have to change the text itself. In fact I think that's already being done for durations like "7d 4h". 6) At one point I had a missing box in the PERT chart. Not sure what it was, but if I see it again I'll let you know. 7) Because the PERT chart has no easy correspondence between the boxes and the tasks in the list on the left, I think it would be nice to have some indicator for when a task is selected (different color, fat border, ...) That's it for today. Thanks, Maurice. -- Maurice van der Pot Gentoo Linux Developer griffon26 gentoo org http://www.gentoo.org Gnome Planner Developer griffon26 kfk4ever com http://live.gnome.org/Planner
Attachment:
pgp9keX68vIYH.pgp
Description: PGP signature