Re: Addition of PERT functionalities to Planner + slip line.

[Alexandre Franke <alexandre franke gmail com>]

On Sun, Jun 14, 2009 at 4:56 PM, Gabriel Camby<gabriel camby gmail com> wrote:
> Hello Planner developpers,

Hi,

> I'm Gabriel Camby. I started working on Planner since the beginning of this
> year. I did a student project on Planner. This project consisted in adding
> PERT features and slip line support in Planner.
> This resulted in a patch, thanks to Maurice van der Pot.

Great news.

> I submitted this patch on Bugzilla adding features from the PERT analysis
> and from project slippage analysis to Planner.
> (http://bugzilla.gnome.org/show_bug.cgi?id=585731)

I was almost sure there was already a bug filed requesting PERT
feature but I couldn't find it anymore.

> Can it be merged in Planner or in a branch?
> I'll be glad if you tell me what you think of it.

Could you split the patch in smaller ones? It would be better to have
one commit per change. This allows to find problems more easily
afterwards (using git bisect for instance) and newcomers can have a
better understanding of the commit history. Also it makes it easier to
review the patches.

Thanks in advance.

-- 
Alexandre Franke