Re: [pinpoint] Some ideas.

[Chris Charles <chris ccharles ca>]

Adjamilton:

It looks like I didn't reply to the list earlier, so I'm replying there 
now.

Please see the attached patch for going to the first slide when you 
press H, h or Home.

I'd be happy to submit this as a feature to the upstream codebase, but 
unfortunately Pinpoint doesn't seem to be set up in the GNOME Bugzilla.

Other list members, is there a good way for me to submit patches? Shall 
I just attach them here? Alternatively, I could set up a git mirror on 
GitHub or something...

~Chris


On Wed, 7 Dec 2011 12:54:58 -0200, Adjamilton Júnior wrote:
> Hi Chris,
>
> I want the patch. Please.
> Pinpoint is the best software for presentation, but some features
> need be implemented.
>
> A. Júnior
>
>  Em 7 de dezembro de 2011 12:27, Chris Charles  escreveu:
>
> > Adjamilton:
> >
> > I also recently found Pinpoint and I really love it. I've offered
> > to submit a few patches, but I haven't gotten any response about
> how
> > to do so.
> >
> > The second feature that you requested, going to the first slide on
> > h/H/Home, is pretty easy to implement. If I can figure out how to
> > submit patches I would be happy to add it.
> >
> > Until then I can send a patch directly to you if you want. It
> > sounds like you'd be comfortable compiling Pinpoint yourself.
> >
> > Please let me know if you want the patch.
> >
> > ~Chris
> >
> > "Adjamilton Júnior" wrote:
> >
> > >Hi guys,
> > >
> > >About a week ago I met pinpoit. This is fantastic.
> > Congratulations.
> > >I've
> > >done a presentation about internationalization (i18n) and
> > localization
> > >(L10n
> > >).
> > >I already know all the features of the program and have studied
> > the
> > >source
> > >code.
> > >There are some things that I think would improve the program:
> > >
> > >1. Add an option (shading-edge = normal | round) to allow the
> > choice
> > >between
> > > normal shading or with edges rounded.
> > >
> > >2. Back to first slide when pressing key: HOME, H or h.
> > >
> > >3. Allow justified text.
> > >
> > >Cheers,
> > >
> > >
> > >Adjamilton Júnior
> > >_______________________________________________
> > >pinpoint-list mailing list
> > >pinpoint-list gnome org [2]
> > >http://mail.gnome.org/mailman/listinfo/pinpoint-list [3]
>
>
>
> Links:
> ------
> [1] mailto:ajunior brasifort com br
> [2] mailto:pinpoint-list gnome org
> [3] http://mail.gnome.org/mailman/listinfo/pinpoint-list
> [4] mailto:chris ccharles ca
From ab10bebc3065d31c192ea313dafbc63d247c2fac Mon Sep 17 00:00:00 2001
From: Chris Charles <chris ccharles ca>
Date: Wed, 7 Dec 2011 09:19:10 -0500
Subject: [PATCH] Add go_home() to go to 1st slide bound to H, Home.

---
 pp-clutter.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/pp-clutter.c b/pp-clutter.c
index 1136033..2d088a9 100644
--- a/pp-clutter.c
+++ b/pp-clutter.c
@@ -769,6 +769,17 @@ clutter_renderer_init_speaker_screen (ClutterRenderer *renderer)
 
 }
 
+static void
+go_home (ClutterRenderer *renderer)
+{
+  if (pp_slides && pp_slidep)
+    {
+      leave_slide (renderer, FALSE);
+      pp_slidep = pp_slides;
+      show_slide (renderer, FALSE);
+    }
+}
+
 static gboolean
 stage_deleted (ClutterStage *stage,
                ClutterEvent *event,
@@ -1383,6 +1394,11 @@ key_pressed (ClutterActor    *actor,
         else
           clutter_actor_show (renderer->curtain);
         break;
+      case CLUTTER_h:
+      case CLUTTER_H:
+      case CLUTTER_Home:
+        go_home (renderer);
+        break;
     }
   return TRUE;
 }
-- 
1.7.7.4