Re: Fwd: ostree static-delta

[Gatis Paeglis <Gatis Paeglis qt io>]

> I have tried my patch on Fedora23 -> Fedora24:

Maybe it is unrelated to that specific patch, but caused by libglnx update in general. I am trying to debug the issue. Here is the strace output soon before an error:

ostree admin upgrade

..

..

unlinkat(8, "staging-327fffce-5489-4c59-95c2-e57b856b53cb-SGXGLY-lock", 0) = 0
close(16)                               = 0
write(13, "\1\0\0\0\0\0\0\0", 8)        = 8
futex(0x63e010, FUTEX_WAKE, 2147483647) = 0
futex(0x63e000, FUTEX_WAKE, 1)          = 1
close(13)                               = 0
close(17)                               = 0
unlinkat(15, "fetcher-4WEGLY-lock", 0)  = -1 EBADF (Bad file descriptor)
close(18)                               = 0
write(1, "\n", 1
)                       = 1
close(3)                                = 0
close(8)                                = 0
close(9)                                = 0
close(7)                                = 0
unlinkat(5, "ostree/lock", 0)           = 0
close(6)                                = 0
close(5)                                = 0
ioctl(1, SNDCTL_TMR_TIMEBASE or SNDRV_TIMER_IOCTL_NEXT_DEVICE or TCGETS, {B38400 opost isig icanon echo ...}) = 0
write(2, "\33[31m\33[1merror: \33[22m\33[0mBad fil"..., 45error: Bad file descriptor
) = 45
exit_group(1)                           = ?
+++ exited with 1 +++

---

From: Giuseppe Scrivano <gscrivan redhat com>
Sent: Monday, July 25, 2016 2:19:53 PM
To: Gatis Paeglis
Cc: Colin Walters; ostree-list gnome org
Subject: Re: Fwd: ostree static-delta

 

Hi,

Gatis Paeglis <Gatis Paeglis qt io> writes:

>> I will see how Giuseppe's patch improves the numbers and post them here later.
>
> The improvement from static delta to patched static delta is 141.9 MB => 124.0 MB
>
>> does tweaking --max-bsdiff-size make any difference?
>
> I tried --min-fallback-size=0 (which as I understand means "always use bsdiff"): --min-fallback-size=0 + your patch = 115,2 MB
>
> A new issue is that with libglnx update (https://github.com/ostreedev/ostree/commit/f3cbe86117d8e68e4dc02c597da59588be31f7e2) I am getting the following error message:

I have tried my patch on Fedora23 -> Fedora24:

$ ostree static-delta generate --min-fallback-size=0 --max-bsdiff-size=100 -v \
  --from=fedora-atomic/f23/x86_64/docker-host --to=fedora-atomic/f24/x86_64/docker-host

...

uncompressed=850049356 compressed=242704945 loose=84153798
rollsum=126 objects, 3165468 bytes
bsdiff=10172 objects

Regards,
Giuseppe