[orca-list] Done: Locking key state changes are now presented independent of key echo

[Joanmarie Diggs <jdiggs igalia com>]

Hey guys.

Thanks for the thoughts and feedback. So to summarize:

* There was only one person who said "keep things as they are."
* Everyone else seemed to feel that locking key state changes should be
  presented independent of key echo.
* Nearly everyone seemed to be fine with my suggestion of removing the
  checkbox from the Preferences dialog.
* Most people seemed to be fine with my suggestion that we'd always
  speak locking key state changes if speech were enabled, but not if
  only speak displayed text was also enabled.
* A couple of people still wanted a way to override this behavior.

With all this in mind, I have just committed the following to master:

* The checkbox is gone.
* We will speak locking key state changes if speech were enabled, but
  not if only speak displayed text was also enabled.
* This can be overridden via orca-customizations.py:

If you want Orca to present locking key state changes even if only speak
displayed text is also enabled do this:

        import orca.settings
        orca.settings.presentLockingKeys = True

If you want Orca to never ever present locking key state changes no
matter what, do this:

        import orca.settings
        orca.settings.presentLockingKeys = False

If you want Orca to do its default (new) behavior, either remove (or
comment out) those lines or set the value to None.

Hope this addresses everyone's concerns and wishes.

Thanks and take care.
--joanie