Re: Orca Traceback when setting up CVS head

[Jorge Sandin <jorges elsendero es>]

Ouch! Willie is right, that was my fault... and that patch should fix it :)

Willie Walker wrote:
> Wow!  Thanks for finding this.  I think it snuck in with the work to
> allow you to modify your keybindings via the preferences GUI.  Can you
> try the following patch to see if it fixes the problem?
>
> Will
>
> Index: orca_prefs.py
> ===================================================================
> RCS file: /cvs/gnome/orca/src/orca/orca_prefs.py,v
> retrieving revision 1.17
> diff -p -u -r1.17 orca_prefs.py
> --- orca_prefs.py       13 Dec 2006 01:21:31 -0000      1.17
> +++ orca_prefs.py       20 Dec 2006 20:51:59 -0000
> @@ -370,7 +370,7 @@ def readPreferences():
>  
>      return prefsDict
>  
> -def writePreferences(prefsDict, treeModel):
> +def writePreferences(prefsDict, treeModel=None):
>      """Creates the directory and files to hold user preferences.  Note
>      that callers of this method may want to consider using an ordered
>      dictionary so that the keys are output in a deterministic order.
> @@ -437,7 +437,8 @@ def writePreferences(prefsDict, treeMode
>                  value = prefsDict[key]
>              prefs.writelines("orca.settings.%s = %s\n" % (key, value))
>  
> -    _writeKeyBindingsMap(prefs, treeModel)
> +    if treeModel:
> +        _writeKeyBindingsMap(prefs, treeModel)
>  
>      _writePreferencesPostamble(prefs)
>      prefs.close()
>
> On Wed, 2006-12-20 at 13:55 -0600, Nolan Darilek wrote:
>   
> > Hello. Getting the following when running 'orca -t' with the latest  
> > CVS head. Wondering if anyone else is seeing this, or if something on  
> > my end is out of sync?:
> >
> > ...
> > Enable Braille Monitor?  Enter y or n: n
> >
> > Traceback (most recent call last):
> >    File "/usr/local/stow/orca/lib/python2.4/site-packages/orca/ 
> > orca.py", line 963, in _showPreferencesConsole
> >      module.showPreferencesUI()
> >    File "/usr/local/stow/orca/lib/python2.4/site-packages/orca/ 
> > orca_console_prefs.py", line 361, in showPreferencesUI
> >      logoutNeeded = orca_prefs.writePreferences(prefsDict)
> > TypeError: writePreferences() takes exactly 2 arguments (1 given)
> >
> > Cannot start Orca because it cannot connect
> > to the Desktop.  Please make sure the DISPLAY
> > environment variable has been set.
> >
> > Thanks.
> >
> > ________________________