Re: [PATCH] Block on oneways

[Michael Meeks <michael meeks novell com>]

Hi Jules,

On Wed, 2007-09-26 at 10:11 +0200, Jules Colding wrote:
> http://www.mail-archive.com/orbit-list gnome org/msg00065.html

	Hmm :-)

>An easy, simple and foolproof way to fix this would be to make all
> oneways block while sending data(*).

	Which would (unfortunately) nullify one of the major advantages of
oneways (asynchronicity) - the other end may not be interested in
reading.

>  Another fix would be to put a ref on the connection if the send is
> a oneway, but that fix will be more involved and not as straightforward.

	Hmm; it's clear that when a connection is finally unreffed we need to
do better wrt. sending all the queued data. This I guess ties into the
problems with shutdown and flushing data then. What do we do with
incoming calls on connections we are unreffing ?

	Anyhow - the simplest approach I would have thought would be to keep a
ref on the connection while there is queued data, or at least some form
of weak-ref (right?).

	HTH,

		Michael.

-- 
 michael meeks novell com  <><, Pseudo Engineer, itinerant idiot